feat: initial structure for components and b2b flow #20103
Conversation
| formControlName="poNumber" | ||
| type="text" | ||
| placeholder="{{ 'checkoutB2B.placeholder' | cxTranslate }}" | ||
| value="{{ cartPoNumber$ | async }}" |
There was a problem hiding this comment.
does it affect perf to has a sync directly in form attribute?
wondering if we should subscribe it once in 'div' or 'container'?
There was a problem hiding this comment.
I think it may affect performance. I will try to fix this.
| typeSelected?: string; | ||
| paymentTypesError = false; | ||
|
|
||
| isUpdating$ = combineLatest([ |
There was a problem hiding this comment.
seeing a number of methods without return type, fee free to add them even though in this it makes sens it is a boolean form method name.
There was a problem hiding this comment.
This code will be evaluating, but I will add all needed typing for the final version.
|
|
||
| this.busy$.next(true); | ||
| this.checkoutPaymentTypeFacade | ||
| .setPaymentType(this.typeSelected, poNumberInput) |
There was a problem hiding this comment.
do we need to unsubscribe or we are 100% sure it complete after 1 time?
In the doubt should we add 'take(1)' or sub.add + ngDestroy callback?
There was a problem hiding this comment.
Good catch, I will fix that.
Closes: CXSPA-9388
Major Changes Introduced
OpfB2bCheckoutPaymentTypecomponent structure for B2B payment type handlingOpfCheckoutPaymentAndReviewcomponent for handling B2B payment reviewOpfCheckoutReviewCardcomponent for displaying review informationOpfCheckoutReviewCartDetailscomponent to handle cart information display: cart, entries and promotions